Test-DbaDiskAllocation: Refactor command #10086
Merged
+54
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andreasjordan
commented
Jan 7, 2026
andreasjordan
commented
- Support for Failover Cluster Instances
- Removed ShouldProcess as the command does not change anything
- Changed output (YES - This is breaking)
- Moved code from begin to process for better readability
Member
|
@andreasjordan can you add aliases to those columns then it wont be a breaking change? |
Collaborator
Author
|
Good idea, will update this pr tomorrow. |
Collaborator
Author
|
Now with aliases. |
Member
|
awesome, thank you! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.